Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CALCITE-6530] HTTP Sessions are never expired in Avatica server #246

Merged
merged 1 commit into from
Aug 15, 2024
Merged

[CALCITE-6530] HTTP Sessions are never expired in Avatica server #246

merged 1 commit into from
Aug 15, 2024

Conversation

stoty
Copy link
Contributor

@stoty stoty commented Aug 14, 2024

No description provided.

joshelser
joshelser approved these changes Aug 14, 2024
View reviewed changes
Copy link
Member

@joshelser joshelser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was reading a stackoverflow post and it looks like Jetty defaults this to 30mins when using their web descriptor (which Avatica isn't): https://stackoverflow.com/questions/49300484/how-to-set-the-http-session-timeout-in-jetty-9-embedded

Looks good to me (but I am distant from the codebase). I can't imagine that this needs to be user-configurable, either.

@stoty
Copy link
Contributor Author

stoty commented Aug 14, 2024

I have read the same article :)
Yes, I came to the same conclusion regarding the web descriptor and the default idle timeout.

@stoty
Copy link
Contributor Author

stoty commented Aug 14, 2024

Thanks for the quick reply Josh.

@joshelser
Copy link
Member

I have read the same article :) Yes, I came to the same conclusion regarding the web descriptor and the default idle timeout.

Excellent, I figured as much!

Thanks for the quick reply Josh.

You bet, caught me at a good time and this change looked straightforward 👍🏼

@stoty stoty merged commit 452df11 into apache:main Aug 15, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshelser joshelser joshelser approved these changes

@snuyanzin snuyanzin Awaiting requested review from snuyanzin

@julianhyde julianhyde Awaiting requested review from julianhyde

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stoty @joshelser